sarkaramrit1993 commented on PR #5232: URL: https://github.com/apache/solr/pull/5232#issuecomment-6426380803
Closing in favor of #5238, which has the same change rebased on main as a single commit. Thanks @nick-boss-tech, both findings were real. - CPU double count: our own review caught the same case, so I kept the fix I'd already made. CPU time now comes only from the request log (shard total plus local CPU), and the response header isn't read. - `[subquery]`: I took your `SolrRequestInfo.isNestedRequest()` check and your three tests as they were, plus a javadoc note. You're credited as co-author on the commit and listed in the changelog. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
