sarkaramrit1993 commented on PR #5238: URL: https://github.com/apache/solr/pull/5238#issuecomment-6461747101
Thanks @nick-boss-tech, the v2-only and embedded `qt` fallback cases are real. Pushed a fix in [1f8dc73](https://github.com/apache/solr/pull/5238/commits/1f8dc7354c4101e9ecfa13d3b0a330a3c8be16ab). I fixed it a bit differently. Instead of setting the handler in `SolrCore.execute` and `ApiBag`, `RequestHandlerBase.handleRequest` records the first handler that runs for a request, and the guard checks that. Every dispatch route ends up there, so it covers v1, v2, embedded and delegation in one place, without a new context contract on `SolrRequestHandler` or a change to `SolrCore`. Ping and other same-request delegation stay excluded because the outer handler is recorded first. It also covers a case the path lookup missed: a package update swapping the handler instance while a search is still running. I wrote two smaller regression tests (v2-only handler, embedded `qt` fallback) on a minimal configset. Both fail on the old guard with `expected:<1> but was:<0>` and pass now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
