nick-boss-tech commented on PR #5238: URL: https://github.com/apache/solr/pull/5238#issuecomment-6433025888
Hi Amrit, 🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* I found one remaining case where a successful client search produces no listener event: a v2-only handler, or an embedded `/select` request resolved through the named/default handler fallback. The new guard looks up the path in the v1 handler registry, which can lack the handler that actually served the request. I added three regression tests and a fix that preserves the originally selected handler at dispatch, including through delegation. This keeps ping, pathless internal searches, shard requests and nested subqueries excluded. The [follow-up diff](https://github.com/nick-boss-tech/solr/compare/cc9ea9b1b6b153317217ee458ff6287b5e24cc65...ede5646e2b2281bf4fc1483c2867f0f047088527) is one commit on your current head. At `ede5646e2b2`, all 20 listener tests (including `testCpuTime`) and 18 neighboring tests passed on Linux, with no failures, errors or skips. Tidy was clean, and `check -x test` passed in a clean full clone with `NODE_ENV` unset. On your original production code, all three new tests complete the search successfully and then fail on the callback count: expected 1, actual 0. To take the tested changes as a fast-forward: ```sh git switch solr-11994-hook git fetch https://github.com/nick-boss-tech/solr.git solr-11994-pr5238-submit git merge --ff-only ede5646e2b2281bf4fc1483c2867f0f047088527 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
