janhoy opened a new pull request, #5263:
URL: https://github.com/apache/solr/pull/5263

   https://issues.apache.org/jira/browse/SOLR-18607
   
   Solr started in the foreground writes no PID file — the normal case in 
containers. Three commands failed to cope:
   
   - `solr stop -p <port>` exited 1 without stopping anything. SOLR-15442 
renamed `-Djetty.port` to `-Dsolr.port.listen` everywhere except the stop 
branch's `ps` fallback. All four copies of that pipeline now go through one 
helper, so they cannot drift apart again.
   - `solr stop --all` exited silently when it stopped nothing, because 
`none_stopped` died in a pipeline subshell. Discovery is deliberately unchanged 
— still PID files in `SOLR_PID_DIR` only, so `--all` never reaps another 
installation's nodes.
   - `solr status` without `-p` reported "No Solr nodes are running". It now 
falls back to `SolrProcessManager`'s live process scan, but only when no PID 
file is found.
   
   Net -3 lines in `bin/solr`. New BATS suite covers all three. `solr.cmd` is 
unaffected: it discovers via `netstat`, and writes its `.port` file in the 
foreground branch too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to