github-actions[bot] commented on PR #5263: URL: https://github.com/apache/solr/pull/5263#issuecomment-6682449060
<!-- llm-pr-triage --> **Automated PR triage** (LLM-generated; may be wrong). Checked once, when the PR was opened or marked ready; not updated on later pushes. **1 possible mismatch(es)** between what this change warrants and what the PR includes. | | Warranted? | In PR? | Confidence | Why | |---|---|---|---|---| | ✅ [Jira issue in title](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) | — | yes | — | Already present; not judged. | | ✅ [Changelog](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc#_changelog_types_reference) | fixed | fixed | high | The PR fixes three distinct bugs in the `solr` CLI script and Java tools: `stop -p` failing to find foreground nodes, `status` missing foreground nodes, and `stop --all` silently exiting when no nodes are stopped. These are user-visible bugs with clear symptoms (exit code 1, incorrect status output, silent failure). | | ✅ [Reference Guide update](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) | no | no | high | The changes fix existing behavior of the `solr` CLI commands (`stop`, `status`) to work correctly in all scenarios (foreground/background). No new parameters, configuration options, or API endpoints are introduced, so the Reference Guide documentation for these commands remains accurate. | | ✅ [Upgrade notes](https://github.com/apache/solr/tree/main/solr/solr-ref-guide/modules/upgrade-notes/pages) | no | no | high | The changes are bug fixes that restore intended behavior and do not remove or rename any parameters, APIs, or configuration elements. The behavior change for `solr status` (now listing all running nodes) is a correction of a bug, not a breaking change requiring user action. | | ⚠️ Tests **— missing** | yes | no | high | The PR modifies production logic in `solr/bin/solr`, `SolrProcessManager.java`, and `StatusTool.java`. The diff includes a new BATS test suite (`test_no_pid_file.bats`) which covers the specific scenarios fixed, satisfying the requirement for tests on non-trivial production logic changes. | _⚠️ mismatch, ❔ uncertain or unanswered, ✅ agrees. Matching changelog, docs and test files were hidden from the model; the PR description may still mention them. File presence does not establish adequacy._ Assessed commit `9f3c7c3161813798ecdf96544ef0652fe345ad02`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
