janhoy commented on code in PR #5263:
URL: https://github.com/apache/solr/pull/5263#discussion_r4418359332
##########
solr/core/src/java/org/apache/solr/cli/StatusTool.java:
##########
@@ -243,6 +244,13 @@ public int runTool() throws Exception {
// No URL or port, scan for running processes
Collection<SolrProcess> procs = processMgr.scanSolrPidFiles();
+ if (procs.isEmpty()) {
+ // Solr started in the foreground writes no PID file, so fall back to
the process list
Review Comment:
I'm not sure if Solr needs to write PID anymore. We could transition fully
to `SolrProcessManager` which knows all running processes, the port,
instance-dir, solr-home dir etc, process PID etc. But that is for another day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
