nick-boss-tech commented on PR #5313: URL: https://github.com/apache/solr/pull/5313#issuecomment-6804509171
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* @julianchandras, I tested the current PR head and found that the default startup timeout still overflows. The fallback is already in milliseconds, but the current code multiplies it by 1,000 and then passes it to the ZooKeeper builder as seconds. With the usual default, `Math.toIntExact` throws before the connection attempt. I prepared [a follow-up with a fix and regression tests](https://github.com/nick-boss-tech/solr/compare/358f13d9fdfaed260143a51100cd5657a582d562...a4ce0580ad89ad521a5402e383d96c239cea94fd). It keeps the fallback in milliseconds, uses `EnvUtils` for the startup property, and preserves precedence for an explicitly supplied legacy system property when an environment variable is also set. <details> <summary>Linux verification</summary> At follow-up head `a4ce0580ad89ad521a5402e383d96c239cea94fd`: - `EnvUtilsTest`: 20 tests passed. - `TestSolrXml`: 37 tests passed and one pre-existing test was skipped. - `ZkFailoverTest`: one test passed. - `tidy` left a clean tree, and `check -x test` passed. - Startup and wire probes passed. The new startup test reproduced the overflow on the PR head; the precedence regression tests failed as expected on the earlier follow-up head. Docker-dependent tests and native Windows/Cygwin behavior were not tested. [Verification receipt](https://github.com/nick-boss-tech/solr/blob/f7b1dcd3fa0ff23548f1f5036837f24b65c3acb5/records/receipt/solr-18630-pr5313-receipt-adjudication-20261111-receipt.json). </details> If useful, you can take the tested commits or adapt the changes: ```sh git switch SOLR-18630-wait-for-zk git fetch https://github.com/nick-boss-tech/solr.git solr-18630-submit git merge --ff-only a4ce0580ad89ad521a5402e383d96c239cea94fd ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
