dsmiley commented on code in PR #5313:
URL: https://github.com/apache/solr/pull/5313#discussion_r4508251916
##########
changelog/unreleased/SOLR-18630-wait-for-zk.yml:
##########
@@ -0,0 +1,8 @@
+title: The default wait for ZooKeeper at node startup is 30 seconds again
instead of 30000, and the deprecated -DwaitForZk system property works again
with a deprecation warning
Review Comment:
I'm going to be pedantic here: `-DwaitForZk` is java CLI flag that sets the
`waitForZk` system property. It's not itself the system property. IMO just
reference the latter; there are multiple ways to set a system property.
##########
solr/core/src/java/org/apache/solr/core/NodeConfig.java:
##########
@@ -266,6 +263,13 @@ public static NodeConfig loadNodeConfig(Path solrHome,
Properties nodeProperties
return SolrXmlConfig.fromSolrHome(solrHome, nodeProperties);
}
+ // Someday this could be inlined...
+ static int getStartUpZkTimeOutSeconds() {
+ Integer waitSeconds = Integer.getInteger("solr.cloud.wait.for.zk.seconds");
Review Comment:
are we avoiding EnvUtils for some reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
