dsmiley commented on PR #5313:
URL: https://github.com/apache/solr/pull/5313#issuecomment-6742189977
Eric, this is another case of you (in #3312) publicizing
(`solr-properties.adoc`) a very internal/test thing that shouldn't have been
publicized. If you read this block of code, it begins with:
```
// TODO: Only job of this block is to
// delay starting a solr core to satisfy
// ZkFailoverTest test case...
```
Which is itself sad... there's a fair amount of production code here in
support of one test.
I don't see any context as to how the problem was discovered @julianchandras
. Does this related to that test or perhaps simply found it via code
inspection? Or, does this affect Solr in the real world? If the latter, then
the comment is inaccurate as it apparently serves a production purpose.
@janhoy added the comment in 2023. The underlying code to connect to ZK here
was added by @gus-asf in #416 in 2021.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
