epugh commented on PR #2391: URL: https://github.com/apache/solr/pull/2391#issuecomment-6872060385
I picked this branch up to exercise the embedded-ZK-quorum role end-to-end via `bin/solr -e cloud`, and ended up pushing a few follow-on commits: - **Exercise the quorum role in the cloud example** — `bin/solr -e cloud` now defaults to forming its own 3-node embedded ZK ensemble (prompting for ensemble size + any additional plain nodes), fixing a couple of concurrency/port-spacing bugs along the way (`DefaultExecutor` thread-safety, ZK's internal client/quorum/leader port offsets colliding across nodes). - **`bin/solr assert --cloud-nodes <N>`** — a new assertion for "at least N SolrCloud nodes are live", with `RunExampleTool` reusing it for its own readiness check instead of a duplicated polling loop. - **Live ensemble joins via ZK dynamic reconfiguration** — a new node with the `zookeeper_quorum` role can now join an already-running ensemble (detected via a live `getConfig()` probe) without restarting the existing members, using `ZooKeeperAdmin.reconfigure()`. Requires `reconfigEnabled=true` and `zookeeper.skipACL=yes` (ZK hardcodes `/zookeeper/config`'s ACL regardless of the provider in use — ZOOKEEPER-2014 — so anonymous reconfig needs this; same open posture the rest of this quorum already runs with). - **A handful of correctness fixes** surfaced by code review and by actually running `TestEmbeddedZkQuorum` for the first time (it hadn't compiled since the merge from main): missing chroot-stripping/trim() on zkHost parsing, a race between cold-bootstrap and the join-detection probe, a `NewConfigNoQuorum` rejection when a stopped node rejoins under its original identity, two NPEs in `MiniSolrCloudCluster`'s quorum mode, and a couple of test-framework compile errors left over from the main merge. All pushed to this branch; happy to pull any of it into separate PRs if that's more useful for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
