janhoy commented on code in PR #2391:
URL: https://github.com/apache/solr/pull/2391#discussion_r4642546053


##########
solr/packaging/test/test_assert.bats:
##########
@@ -41,6 +41,9 @@ teardown() {
   assert_output --partial "ERROR: Solr is not running in cloud mode"
 
   run ! solr assert --cloud http://localhost:${SOLR_PORT} --exitcode
+
+  run solr assert --cloud-nodes 1 --solr-url http://localhost:${SOLR_PORT} 
--timeout 0 --exitcode

Review Comment:
   🤖 This PR adds `solr assert --cloud-nodes` checks to `test_assert.bats`, 
including a second node. BATS is going away: CATS (SOLR-18642, #5323) has 
replaced it on `main`, and SOLR-18645 (#5369) removes the `.bats` files. Please 
port these to `AssertTest` in `solr/packaging/src/test/org/apache/solr/shell/`. 
See 
[dev-docs/cats.adoc](https://github.com/apache/solr/blob/main/dev-docs/cats.adoc)
 for porting help.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to