epugh commented on PR #2391:
URL: https://github.com/apache/solr/pull/2391#issuecomment-6879363990

   Small follow-up worth tracking (not a blocker, just a note so it doesn't get 
lost): `ZookeeperStatusHandler` (`/admin/zookeeper/status`) derives 
`ensembleSize`/`details` from whichever node answers' own **static** `-z` 
connection string at *its own startup*, not from a fresh query of ZK's actual 
current dynamic membership. That was a completely reasonable design until now — 
`-z` has always been static for the life of a Solr cluster, until this 
`zookeeper_quorum` live-join capability.
   
   Concretely: if you grow a 3-node embedded quorum to 4 via a live join (a 
brand new node added through `reconfigure()`), querying the status endpoint 
through one of the *original* 3 nodes still reports `ensembleSize: 3` — it only 
shows the fuller picture if you happen to query a node that was started *after* 
the join (which was given the grown `-z` list at its own boot). The real, 
current membership is right there via ZK's own `getConfig()` dynamic config the 
handler already fetches for the `dynamicReconfig` flag — it's just not being 
used to recompute `ensembleSize`/`details` against.
   
   Probably a small, contained fix (prefer the live dynamic config over the 
static `-z` string when they disagree) but flagging now so it doesn't get lost 
before GA.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to