nick-boss-tech commented on PR #5319:
URL: https://github.com/apache/solr/pull/5319#issuecomment-6880466761

   🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)*
   
   I checked the routing names on a few v2 surfaces at this PR’s current head:
   
   | Surface | Parameter | Finding |
   |---|---|---|
   | Detailed collection list | `route` | With this PR, `route` selects the 
shard; `_route_` is ignored. |
   | V2 `/select` | `_route_` | In an HTTP probe, `_route_` narrowed the 
results to the selected shard; `route` was ignored. |
   | V2 real-time get | `_route_` | In an HTTP probe, `_route_` selected the 
target shard; `route` was ignored. |
   | V2 updates | `_route_` | The v2 endpoints pass requests to the existing 
update handler. The source indicates that request-level delete routing reads 
`_route_`; I did not separately probe v2 updates over HTTP. |
   | V2 add replica | `route` | The [request 
model](https://github.com/apache/solr/blob/babbdaeee25b3ee4687fd1f6a6cef66a9e2d16ed/solr/api/src/java/org/apache/solr/client/api/model/CreateReplicaRequestBody.java)
 has a `route` body field. In an HTTP probe, the required shard in the URL took 
precedence over a conflicting route value. |
   
   So there is a v2 `route` naming example, but it appears to be a limited 
routing precedent. The existing v2 `/select` behavior supports David’s 
consistency concern. It may be useful to decide whether new v2 interfaces 
should retain `_route_`, use `route`, or accept both, with compatibility for 
existing callers in mind.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to