nick-boss-tech commented on PR #5319: URL: https://github.com/apache/solr/pull/5319#issuecomment-6882669524
🤖 *AI text below* 🤖 *(reviewed by Nick Shanin)* I looked through the history. The name was chosen as part of an effort to use one routing parameter across routers, queries, and updates. In the [2013 discussion](https://issues.apache.org/jira/browse/SOLR-5017?focusedCommentId=13704561&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13704561), `_shard_` was considered misleading because the value can be input to a router rather than a literal shard name. The group settled on `_route_` and deprecated the query parameter `shard.keys`. There is also an earlier [proposal](https://issues.apache.org/jira/browse/SOLR-2592?focusedCommentId=13502577&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13502577) to match a special `_shard_` document field and request parameter, using `_version_` as an example. I haven’t found a broader rule requiring underscores on request parameters, though. That history explains the consistency David called out, but it doesn’t settle whether `route` would be a better name going forward. If that is the direction, existing callers of `_route_` would need consideration across the affected APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
