dsmiley commented on PR #5319:
URL: https://github.com/apache/solr/pull/5319#issuecomment-6889803643

   My suspicion is that it's creator used the wrapping underscores as a way of 
separating this param from those at higher levels of the stack within Solr.  
Query parsers, request handlers, search components, are all at the top and 
generally don't use underscores.  But this one is a routing one; it's at a 
layer below -- well sorta.  SearchHandler uses it but I view what S.H. does as 
special because it's the components it holds that actually *do* stuff.  One 
might say all "routing" parameters are special -- I think so.  `_stateVer_` is 
another, which again is at a layer below (and I want to replace with with an 
HTTP header BTW -- again, a layer below).  Ideally there would be consistency 
in the approach, but there just isn't.  If it were up to me, a leading 
underscore would precede all "lower level params" -- params general to 
routing/request processing that aren't specific to the business of the handler 
on up.  Thus, say, timeAllowed.  And everything in `ShardParams`.  Any way, 
there 
 are so few cases that maybe we just drop the wrapping underscores for all 
params involving v2, instead of adding them.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to