[
https://issues.apache.org/jira/browse/STORM-2937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16354781#comment-16354781
]
Jungtaek Lim edited comment on STORM-2937 at 2/7/18 12:27 AM:
--------------------------------------------------------------
{quote}Gigantic commits are often a problem for this, especially given how bad
the majority of folks are at writing commit messages and code comments.
{quote}
I'm in favor of squashing commits for the same reason. I don't think commits
like "addressing review comments" will help us finding the root cause while
debugging and "git blame", and composing a unit of commit is also what majority
of contributors/even PMCs are not doing well. Everyone has different standard
about the unit, hence that can be easily led to debate as well.
For guaranteeing quality of commit message, we can force PR to fill the
template of PR and adding it to commit body, which is what other projects are
doing and makes more sense than relying on contributors.
Similar feeling with merge commit, since it enables reverting whole the commits
at once (per PR), but commits are not in line with effective date. Commit log
of merge commit doesn't give informative thing, and I should find JIRA,
relevant commits which are merged in with merge commit. That is less handy than
squashing and push itself without adding merge commit.
was (Author: kabhwan):
{quote}Gigantic commits are often a problem for this, especially given how bad
the majority of folks are at writing commit messages and code comments.
{quote}
I'm in favor of squashing commits for the same reason. I don't think commits
like "addressing review comments" will help us finding the root cause while
debugging and "git blame". For guaranteeing quality of commit message, we can
force PR to fill the template of PR and adding it to commit body, which is what
other projects are doing and makes more sense than relying on contributors.
Similar feeling with merge commit, since it enables reverting whole the commits
at once (per PR), but commits are not in line with effective date. Commit log
of merge commit doesn't give informative thing, and I should find JIRA,
relevant commits which are merged in with merge commit. That is less handy than
squashing and push itself without adding merge commit.
> Overwrite storm-kafka-client 1.x-branch into 1.0.x-branch
> ---------------------------------------------------------
>
> Key: STORM-2937
> URL: https://issues.apache.org/jira/browse/STORM-2937
> Project: Apache Storm
> Issue Type: Task
> Components: storm-kafka-client
> Affects Versions: 1.0.6
> Reporter: Jungtaek Lim
> Assignee: Erik Weathers
> Priority: Blocker
>
> This is to track the effort of syncing up divergence between
> storm-kafka-client 1.x-branch and 1.0.x-branch so that critical fixes can be
> go in 1.0.x-branch as well.
> Note that it can modify storm-core as well (unlikely in a
> backwards-incompatible way but not 100% sure), so we should make a decision
> whether we allow the change in bugfix version line.
> Linking discussion thread:
> [https://lists.apache.org/thread.html/0451fed132bb982b618d9e0780282a87554f1bc5747827599f276944@%3Cdev.storm.apache.org%3E]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
