sercuzz8 opened a new pull request, #8969: URL: https://github.com/apache/storm/pull/8969
## Purpose Update `storm_checkstyle.xml` to follow Google conventions [`google_checks.xml`](https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml) There is no strong rationale but I saw it was originally used as a [base](https://github.com/apache/storm/commit/88cf6f7b4). Changes: - Splits `OperatorWrap` into `OperatorWrapNL`/`OperatorWrapEOL` so lambdas get upstream's dedicated EOL wrap rule. - Adds the missing `BoxComments` variant of `TodoComment`, catching box-like repetitive comment banners (e.g. `// ====...`). - Tightens the `IndentationCheck` suppression regex to upstream's anchored form. * Also added `NewlineAtEndOfFile` to follow [POSIX's line definition](https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206). ## Tests and Implementation 1. `mvn -pl storm-checkstyle install -DskipTests` to rebuild the shared ruleset artifact. 1. `mvn validate` across the full reactor (OK with `BUILD SUCCESS` or `0 Checkstyle violations` / KO warranted code correction on interested lines until OK). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
