GGraziadei commented on PR #8969: URL: https://github.com/apache/storm/pull/8969#issuecomment-5188175643
Hi @sercuzz8, thanks for your effort and for driving this initiative! To summarize where we stand on this issue [apache/storm#8585 (comment)](https://github.com/apache/storm/issues/8585#issuecomment-4472473373), @sigee outlined the upgrade steps: - Steps 1 and 2 (Completed): Bumped Checkstyle and set the non-compliant rules to warning. - Step 3 (**Current**): Resolve the remaining warnings module by module ( via separate PRs per module to keep code reviews manageable). - Step 4 move back the warning in errors That said, fixing these rules manually module by module can become quite tedious. I want to make sure your time and effort deliver the highest possible value to both you and the project. With that in mind, what would you think about exploring an automated approach alongside or before this? For example, configuring a Maven plugin could auto-fix many of these checkstyle warnings across the whole codebase in one go, preventing future technical debt altogether. Either way, it's your call. Once we resolve the module warnings, we can consider aligning our checkstyle rules with the upstream Google manifest. When you're ready for that step, please open a proposal thread on dev@ first so we can gather community consensus. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
