sercuzz8 commented on code in PR #8969:
URL: https://github.com/apache/storm/pull/8969#discussion_r3720980483
##########
bin/storm.py:
##########
@@ -1425,6 +1425,28 @@ def monitor(args):
extrajars=[USER_CONF_DIR, STORM_BIN_DIR])
+def merge_args_preserving_order(sys_args, known_args, unknown_args):
Review Comment:
I did this just because not applying this fix blocked the execution of
```mvn validate``` and ```mvn clean install``` but I agree with this idea.
Just to be sure, can I use the same issue to propose this?
In any case, thank you for the attention and the advice.\
##########
bin/storm.py:
##########
@@ -1425,6 +1425,28 @@ def monitor(args):
extrajars=[USER_CONF_DIR, STORM_BIN_DIR])
+def merge_args_preserving_order(sys_args, known_args, unknown_args):
Review Comment:
I did this just because not applying this fix blocked the execution of
```mvn validate``` and ```mvn clean install``` but I agree with this idea.
Just to be sure, can I use the same issue to propose this?
In any case, thank you for the attention and the advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
