reiabreu commented on code in PR #9172:
URL: https://github.com/apache/storm/pull/9172#discussion_r4303177403


##########
storm-client/src/jvm/org/apache/storm/serialization/IKryoDecorator.java:
##########
@@ -20,7 +20,7 @@ public interface IKryoDecorator {
      * Decorate the Kryo instance with custom serializations.
      * @deprecated use {@link #decorate(Kryo, Map)} instead.
      */
-    @Deprecated
+    @Deprecated(since = "2.0.0", forRemoval = true)

Review Comment:
   `decorate(Kryo)` was deprecated together with its replacement in #8452, 
which shipped in 2.8.6 (git history shows no earlier deprecation of this 
class), so `since = "2.0.0"` looks wrong:
   
   ```suggestion
       @Deprecated(since = "2.8.6", forRemoval = true)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to