Mohit20057 commented on PR #9172:
URL: https://github.com/apache/storm/pull/9172#issuecomment-6400242922
@rzo1 Thanks for the thorough review !
I have updated the PR accordingly:
1. Corrected all `since` values to match the release tags:
- `NimbusClient` and `SupervisorClient` constructors/factories: `2.6.4`
- `TopologyContext.registerMetric` / `getRegisteredMetricByName`: `2.0.0`
- `IMetricsContext.registerMetric`: `2.1.0`
- `Config.TOPOLOGY_SPREAD_COMPONENTS`: `2.2.0`
- `INimbusCredentialPlugin.populateCredentials(Map, Map)`: `2.0.0`
- `TransactionAttempt`: `2.0.0`
- `TimeCacheMap`: omitted `since`
2. Changed `forRemoval` to `false` for `TOPOLOGY_SPREAD_COMPONENTS` and
`TimeCacheMap` due to active internal usages.
3. Updated the CGroup V1 `@deprecated` tags to link directly to their
corresponding `org.apache.storm.metrics2.cgroup.*` classes.
4. Rebased onto master, resolved the formatting conflicts from #9184, and
verified `mvn test-compile -pl storm-client` passes cleanly with 0 Checkstyle
violations under JDK 23.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
