rzo1 commented on PR #9172: URL: https://github.com/apache/storm/pull/9172#issuecomment-6387518813
Thanks for working through these. Checking against the release tags, several `since` values seem off: - `NimbusClient` and `SupervisorClient` constructors/factories: 2.6.4 (STORM-4070), not 2.0.0 - `TopologyContext.registerMetric`/`getRegisteredMetricByName`: 2.0.0 (STORM-2909) - `IMetricsContext.registerMetric`: 2.1.0 (STORM-3371) - `Config.TOPOLOGY_SPREAD_COMPONENTS`: 2.2.0 (STORM-3585) - `INimbusCredentialPlugin.populateCredentials(Map, Map)`: 2.0.0 - `TransactionAttempt`: 2.0.0 (STORM-3156) - `TimeCacheMap`: after 0.8.0. I would leave `since` out, since there are no tags that old. Two `forRemoval=true` decisions also look premature to me: - `TOPOLOGY_SPREAD_COMPONENTS`: the multitenant `NodePool` reads only this key, and `TOPOLOGY_RAS_CONSTRAINTS` applies only to the constraint solver. - `TimeCacheMap` is still used by `CoordinatedBolt`. Either `forRemoval=false` for now, or migrate those usages first. Minor: the CGroup V1 `@deprecated` tags could point to the matching `org.apache.storm.metrics2.cgroup.*` class rather than to the registry in general. The conflicts are from #9184 and should be mechanical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
