1996fanrui commented on code in PR #2268: URL: https://github.com/apache/incubator-streampark/pull/2268#discussion_r1094519802
########## streampark-console/streampark-console-service/src/main/assembly/script/schema/mysql-schema.sql: ########## @@ -210,12 +210,19 @@ drop table if exists `t_flink_savepoint`; create table `t_flink_savepoint` ( `id` bigint not null auto_increment, `app_id` bigint not null, + `job_id` VARCHAR(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL, + `status` VARCHAR(255) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 'COMPLETED', `chk_id` bigint default null, `type` tinyint default null, - `path` varchar(255) collate utf8mb4_general_ci default null, + `path` varchar(2048) collate utf8mb4_general_ci default null, `latest` tinyint not null default 1, `trigger_time` datetime default null, + `execution_mode` VARCHAR(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL, Review Comment: Why need the `execution_mode` here? ########## streampark-console/streampark-console-service/src/main/assembly/script/schema/mysql-schema.sql: ########## @@ -210,12 +210,19 @@ drop table if exists `t_flink_savepoint`; create table `t_flink_savepoint` ( `id` bigint not null auto_increment, `app_id` bigint not null, + `job_id` VARCHAR(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL, + `status` VARCHAR(255) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT 'COMPLETED', `chk_id` bigint default null, `type` tinyint default null, - `path` varchar(255) collate utf8mb4_general_ci default null, + `path` varchar(2048) collate utf8mb4_general_ci default null, `latest` tinyint not null default 1, `trigger_time` datetime default null, + `execution_mode` VARCHAR(255) COLLATE utf8mb4_unicode_ci DEFAULT NULL, + `cluster_id` bigint DEFAULT NULL, Review Comment: And why need the cluster_id? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
