RocMarshal commented on code in PR #2268:
URL:
https://github.com/apache/incubator-streampark/pull/2268#discussion_r1094643781
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/CheckpointProcessor.java:
##########
@@ -108,6 +112,23 @@ public void process(Long appId, CheckPoints checkPoints) {
}
}
+ private boolean shouldProcessFailedTrigger(
+ CheckPoints.CheckPoint checkPoint, Application application,
CheckPointStatus status) {
+ return CheckPointStatus.FAILED.equals(status)
+ && !checkPoint.getIsSavepoint()
+ && application.cpFailedTrigger();
+ }
+
+ private boolean checkpointNeedStore(
+ Application application, @Nonnull CheckPoints.CheckPoint checkPoint) {
+ LambdaQueryWrapper<SavePoint> queryWrapper =
Review Comment:
A minor confusion for me form the comments.
Does the minor refactor cause the logic loss or the original implementation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
