1996fanrui commented on code in PR #2268:
URL:
https://github.com/apache/incubator-streampark/pull/2268#discussion_r1096473616
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/CheckpointProcessor.java:
##########
@@ -108,6 +112,23 @@ public void process(Long appId, CheckPoints checkPoints) {
}
}
+ private boolean shouldProcessFailedTrigger(
+ CheckPoints.CheckPoint checkPoint, Application application,
CheckPointStatus status) {
+ return CheckPointStatus.FAILED.equals(status)
+ && !checkPoint.getIsSavepoint()
+ && application.cpFailedTrigger();
+ }
+
+ private boolean checkpointNeedStore(
+ Application application, @Nonnull CheckPoints.CheckPoint checkPoint) {
+ LambdaQueryWrapper<SavePoint> queryWrapper =
Review Comment:
I mean we still use the old logic.
The code of the master branch determines whether checkpoint/savepoint needs
to be stored in the database according to the cache, and I think it is enough
for now. Your code will access to the database frequently, it isn't friendly to
database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
