RocMarshal commented on code in PR #2268:
URL:
https://github.com/apache/incubator-streampark/pull/2268#discussion_r1109911711
##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesNativeSessionSubmit.scala:
##########
@@ -212,4 +212,9 @@ object KubernetesNativeSessionSubmit extends
KubernetesNativeSubmitTrait with Lo
Utils.close(kubeClient)
}
}
+
+ override def doTriggerSavepoint(request: TriggerSavepointRequest,
flinkConfig: Configuration): SavepointResponse = {
+ flinkConfig.safeSet(DeploymentOptions.TARGET,
ExecutionMode.KUBERNETES_NATIVE_APPLICATION.getName)
Review Comment:
The lines is coded follow the original lines in the class.
@wolfboys could you help check it ? I'm not familiar with the k8s execution
mode. As mentioned above comments, I test for the feature on all execution mode
besides k8s mode.
CC @1996fanrui
thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
