RocMarshal commented on code in PR #2268:
URL:
https://github.com/apache/incubator-streampark/pull/2268#discussion_r1110522915
##########
streampark-flink/streampark-flink-client/streampark-flink-client-core/src/main/scala/org/apache/streampark/flink/client/impl/KubernetesNativeSessionSubmit.scala:
##########
@@ -212,4 +212,9 @@ object KubernetesNativeSessionSubmit extends
KubernetesNativeSubmitTrait with Lo
Utils.close(kubeClient)
}
}
+
+ override def doTriggerSavepoint(request: TriggerSavepointRequest,
flinkConfig: Configuration): SavepointResponse = {
+ flinkConfig.safeSet(DeploymentOptions.TARGET,
ExecutionMode.KUBERNETES_NATIVE_APPLICATION.getName)
Review Comment:
> Is it a bug?
Confirmed with @wolfboys offline. It's a bug. I fixed it.
PTAL. :)
Thank you @wolfboys @1996fanrui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
