1996fanrui commented on code in PR #2268:
URL:
https://github.com/apache/incubator-streampark/pull/2268#discussion_r1111255615
##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/task/CheckpointProcessor.java:
##########
@@ -52,30 +66,32 @@ public class CheckpointProcessor {
@Autowired private SavePointService savePointService;
- public void process(Long appId, CheckPoints checkPoints) {
- CheckPoints.Latest latest = checkPoints.getLatest();
- if (latest == null || latest.getCompleted() == null) {
- return;
- }
- CheckPoints.CheckPoint checkPoint = latest.getCompleted();
- Application application = applicationService.getById(appId);
+ public void process(Application application, @Nonnull CheckPoints
checkPoints) {
+ checkPoints.getLatestCheckpoint().forEach(checkPoint ->
process(application, checkPoint));
+ }
+
+ private void process(Application application, @Nonnull
CheckPoints.CheckPoint checkPoint) {
+ String jobID = application.getJobId();
+ Long appId = application.getId();
CheckPointStatus status = checkPoint.getCheckPointStatus();
if (CheckPointStatus.COMPLETED.equals(status)) {
- String cacheId = appId + "_" + application.getJobId();
- Long latestId =
- checkPointCache.get(
- cacheId,
- key -> {
- SavePoint savePoint = savePointService.getLatest(appId);
- return
Optional.ofNullable(savePoint).map(SavePoint::getChkId).orElse(null);
- });
-
- if (latestId == null || latestId < checkPoint.getId()) {
- saveSavepoint(checkPoint, application);
+ String cacheId = getCacheIdForCheckpoint(appId, jobID);
+ Long latestChkId = getLatestCheckpointedId(appId, cacheId);
+ if (shouldStoreAsSavepoint(appId, jobID, checkPoint)) {
+ savepointedCache.put(
+ getCacheIdForSavepoint(appId, jobID, checkPoint.getId()),
DEFAULT_FLAG_BYTE);
+ saveSavepoint(
+ checkPoint,
+ application.getId(),
+ latestChkId == null || checkPoint.getId() > latestChkId);
+ return;
+ }
+ if (shouldStoreAsCheckpoint(checkPoint, latestChkId)) {
Review Comment:
By the way, the cache still have bug when streampark restarts.
Because the cache will be empty after restart. So I prefer do less here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
