[
https://issues.apache.org/jira/browse/WW-5000?focusedWorklogId=532884&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532884
]
ASF GitHub Bot logged work on WW-5000:
--------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/21 07:51
Start Date: 08/Jan/21 07:51
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on a change in pull request #464:
URL: https://github.com/apache/struts/pull/464#discussion_r553790748
##########
File path:
core/src/test/java/com/opensymphony/xwork2/ognl/accessor/XWorkListPropertyAccessorTest.java
##########
@@ -85,7 +85,7 @@ public void testAutoGrowthCollectionLimit() {
public void testDeprecatedAutoGrowCollectionLimit() {
Review comment:
Good catch, dropped!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 532884)
Time Spent: 2h 10m (was: 2h)
> Replace string literals with proper constants in @Inject
> --------------------------------------------------------
>
> Key: WW-5000
> URL: https://issues.apache.org/jira/browse/WW-5000
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Priority: Minor
> Fix For: 2.6
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> In many places string literals are used instead of a proper reference to a
> constant.
> {noformat}
> @Inject(value = "struts.xwork.chaining.copyMessages", required = false)
> @Inject(value = "struts.xwork.chaining.copyFieldErrors", required = false)
> @Inject(value = "struts.xwork.chaining.copyErrors", required = false)
> @Inject(value = "struts.javatemplates.defaultTemplateType", required = false)
> @Inject(value = "struts.javatemplates.customThemes", required = false)
> @Inject(value = "struts.objectFactory.cdi.jndiKey", required = false)
> @Inject(value = "enableAopSupport", required = false)
> @Inject(value = "struts.oval.validateJPAAnnotations")
> @Inject(value = "xwork.autoGrowCollectionLimit", required = false)
> @Inject(value = "logMissingProperties", required = false)
> @Inject(value="objectFactory.classloader", required=false)
> @Inject(value="allowStaticMethodAccess", required=false)
> @Inject(value="applicationContextPath",required=false)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
