[jira] [Work logged] (WW-5000) Replace string literals with proper constants in @Inject

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/WW-5000?focusedWorklogId=533591&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-533591
 ]

ASF GitHub Bot logged work on WW-5000:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jan/21 03:59
            Start Date: 10/Jan/21 03:59
    Worklog Time Spent: 10m 
      Work Description: coveralls edited a comment on pull request #464:
URL: https://github.com/apache/struts/pull/464#issuecomment-753592218


   
   [![Coverage 
Status](https://coveralls.io/builds/36185782/badge)](https://coveralls.io/builds/36185782)
   
   Coverage increased (+0.04%) to 49.861% when pulling 
**83838d1b9ad89db157ab22c48ff31c4f239460f7 on WW-5000-constants** into 
**dcc53aebf983f6c0a48932262facb81f5d82815c on master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 533591)
    Time Spent: 2.5h  (was: 2h 20m)

> Replace string literals with proper constants in @Inject
> --------------------------------------------------------
>
>                 Key: WW-5000
>                 URL: https://issues.apache.org/jira/browse/WW-5000
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.6
>
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> In many places string literals are used instead of a proper reference to a 
> constant.
> {noformat}
> @Inject(value = "struts.xwork.chaining.copyMessages", required = false)
> @Inject(value = "struts.xwork.chaining.copyFieldErrors", required = false)
> @Inject(value = "struts.xwork.chaining.copyErrors", required = false)
> @Inject(value = "struts.javatemplates.defaultTemplateType", required = false)
> @Inject(value = "struts.javatemplates.customThemes", required = false)
> @Inject(value = "struts.objectFactory.cdi.jndiKey", required = false)
> @Inject(value = "enableAopSupport", required = false)
> @Inject(value = "struts.oval.validateJPAAnnotations")
> @Inject(value = "xwork.autoGrowCollectionLimit", required = false)
> @Inject(value = "logMissingProperties", required = false)
> @Inject(value="objectFactory.classloader", required=false)
> @Inject(value="allowStaticMethodAccess", required=false)
> @Inject(value="applicationContextPath",required=false)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)