[ 
https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=873658&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873658
 ]

ASF GitHub Bot logged work on WW-5327:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Jul/23 08:56
            Start Date: 30/Jul/23 08:56
    Worklog Time Spent: 10m 
      Work Description: kusalk commented on code in PR #715:
URL: https://github.com/apache/struts/pull/715#discussion_r1278534244


##########
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java:
##########
@@ -482,12 +482,22 @@ public void clearContextValues() {
         ((OgnlContext) context).getValues().clear();
     }
 
+    @Deprecated
     public void setAcceptProperties(Set<Pattern> acceptedProperties) {
-        securityMemberAccess.setAcceptProperties(acceptedProperties);
+        throw new UnsupportedOperationException("Please use 
#useAcceptProperties instead!");

Review Comment:
   Doesn't this defeat the purpose of deprecating and retaining these methods? 
May as well delete them if they're not functional





Issue Time Tracking
-------------------

    Worklog Id:     (was: 873658)
    Time Spent: 40m  (was: 0.5h)

> Stop using JavaBeans notation for setters in SecurityMemberAccess & 
> MemberAccessValueStack
> ------------------------------------------------------------------------------------------
>
>                 Key: WW-5327
>                 URL: https://issues.apache.org/jira/browse/WW-5327
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Lukasz Lenart
>            Priority: Major
>             Fix For: 6.3.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Avoid using set* notations



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to