[
https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=873683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873683
]
ASF GitHub Bot logged work on WW-5327:
--------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/23 05:30
Start Date: 31/Jul/23 05:30
Worklog Time Spent: 10m
Work Description: lukaszlenart commented on code in PR #715:
URL: https://github.com/apache/struts/pull/715#discussion_r1278807713
##########
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java:
##########
@@ -482,12 +482,22 @@ public void clearContextValues() {
((OgnlContext) context).getValues().clear();
}
+ @Deprecated
public void setAcceptProperties(Set<Pattern> acceptedProperties) {
- securityMemberAccess.setAcceptProperties(acceptedProperties);
+ throw new UnsupportedOperationException("Please use
#useAcceptProperties instead!");
Review Comment:
My idea was to give a clear signal that these methods shouldn't be used
anymore as they can degrade security. I will remove them in the [next
version](https://issues.apache.org/jira/browse/WW-5328)
Issue Time Tracking
-------------------
Worklog Id: (was: 873683)
Time Spent: 1h (was: 50m)
> Stop using JavaBeans notation for setters in SecurityMemberAccess &
> MemberAccessValueStack
> ------------------------------------------------------------------------------------------
>
> Key: WW-5327
> URL: https://issues.apache.org/jira/browse/WW-5327
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 6.3.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Avoid using set* notations
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
