[
https://issues.apache.org/jira/browse/WW-5327?focusedWorklogId=873685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-873685
]
ASF GitHub Bot logged work on WW-5327:
--------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jul/23 05:34
Start Date: 31/Jul/23 05:34
Worklog Time Spent: 10m
Work Description: kusalk commented on code in PR #715:
URL: https://github.com/apache/struts/pull/715#discussion_r1278809579
##########
core/src/main/java/com/opensymphony/xwork2/ognl/OgnlValueStack.java:
##########
@@ -482,12 +482,22 @@ public void clearContextValues() {
((OgnlContext) context).getValues().clear();
}
+ @Deprecated
public void setAcceptProperties(Set<Pattern> acceptedProperties) {
- securityMemberAccess.setAcceptProperties(acceptedProperties);
+ throw new UnsupportedOperationException("Please use
#useAcceptProperties instead!");
Review Comment:
I'd personally just delete them if that's the signal you want to give.
Deprecating methods traditionally means they can still be used and will
redirect to the replacing method where possible.
Issue Time Tracking
-------------------
Worklog Id: (was: 873685)
Time Spent: 1h 10m (was: 1h)
> Stop using JavaBeans notation for setters in SecurityMemberAccess &
> MemberAccessValueStack
> ------------------------------------------------------------------------------------------
>
> Key: WW-5327
> URL: https://issues.apache.org/jira/browse/WW-5327
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 6.3.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Avoid using set* notations
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
