http://openoffice.org/bugzilla/show_bug.cgi?id=117814
--- Comment #24 from [email protected] 2011-04-12 14:35:38 --- There's a very ugly hack for code dealing with OLE objects when a document is copied: in case this document is a pure SwDoc without an assoicated SwDocShell (now: without an associated IDocShell), a temporary SwDocShell is created deep in the core and it is stored as "TempDocShell" object in the SwDoc instance. The caller of the code uses its existence as a sign that there have been some OLE copied and treats the document accordingly. This is ugly for several reasons, the unnecessary dependency on SwDocShell in the core being only one of them. So I reverted this: the code that is aware of the "pure" SwDoc (what can be spotted from the existence of code that checks for the TempDocShell afterwards) now creates a TempDocShell and the code in the core expects it to be there. As the code that now creates the TempDocShell is in ui, the dependency on SwDocShell in ndole.cxx is gone. The caller checks the TempDocShell explicitly whether it contains OLE objects or not. changeset c39e66ed8436 http://hg.services.openoffice.org/cws/swcoreseparation/rev/c39e66ed8436 -- Configure bugmail: http://openoffice.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Bugzilla. Please log into the website and enter your comments. --------------------------------------------------------------------- -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help
