http://openoffice.org/bugzilla/show_bug.cgi?id=117814
--- Comment #25 from [email protected] 2011-04-12 15:00:04 --- The final dependencies on ui in core and filter result from some places where an SwDocShell must be created. Though we don't need the SwDocShell objects themselves but only the SwDoc objects they contain, we need to go through the SwDocShell creation as otherwise we don't have an IDocShell pointer set at the SwDoc object. The whole refactoring is just an intermediate step to the final goal where all document related core functionality can be handled by core and filter code alone. This of course also comprises the creation of a document. Of course such a document wouldn't be an SwDocShell but rather an SwDoc completed by some functionality currently in SwDocShell and SfxObjectShell. OTOH it's rather unfortunate that the current SwDocShell is so "fat", so leaving it bound to the core code is not an option as it would set us on risk to lose all the achievements gained so far because we can't verify by a build that no new unnecessary dependencies have been added. Thus an intermediate workaround is applied: SwDocShell/SwDoc combinations are created via a factory method that is handed over to the class SwDoc. This allows us create a makefile for an swcore lib that should build and also shoud be sufficient to link the msfilter lib. To verify that we didn't add any new ui dependency to the core, it's enough to call make clean export SWCORE=TRUE make in the sw module. This should create an swcorelib and an msfilterlib. changeset 85111b8481f2 http://hg.services.openoffice.org/cws/swcoreseparation/rev/85111b8481f2 -- Configure bugmail: http://openoffice.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Bugzilla. Please log into the website and enter your comments. --------------------------------------------------------------------- -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help -- ----------------------------------------------------------------- To unsubscribe send email to [email protected] For additional commands send email to [email protected] with Subject: help
