[
https://issues.apache.org/jira/browse/TAJO-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294652#comment-14294652
]
ASF GitHub Bot commented on TAJO-1320:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/363#discussion_r23663460
--- Diff:
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseStorageConstants.java
---
@@ -27,6 +27,7 @@
public static final String META_SPLIT_ROW_KEYS_KEY =
"hbase.split.rowkeys";
public static final String META_SPLIT_ROW_KEYS_FILE_KEY =
"hbase.split.rowkeys.file";
public static final String META_ZK_QUORUM_KEY = "hbase.zookeeper.quorum";
+ public static final String META_ZK_CLIENT_PORT =
"hbase.zookeeper.property.clientPort";
--- End diff --
We traditionally avoid the Camel style for configuration key names.
And, we need to make the naming style consistent.
So, how about ```hbase.zookeeper.client.port```?
> HBaseStorageManager need to support Zookeeper Client Port.
> ----------------------------------------------------------
>
> Key: TAJO-1320
> URL: https://issues.apache.org/jira/browse/TAJO-1320
> Project: Tajo
> Issue Type: Improvement
> Components: storage
> Reporter: Jaehwa Jung
> Assignee: Jaehwa Jung
> Fix For: 0.10
>
> Attachments: TAJO-1320.patch
>
>
> Currently, HBaseStorageManager just use Zookeeper Quorum host names. But I
> think that users may want to change their Zookeeper client port. Thus, we
> need to support that users can set the port. For reference, HBase defines the
> port to ZOOKEEPER_CLIENT_PORT in HBaseConstants.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
