[ 
https://issues.apache.org/jira/browse/TAJO-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294659#comment-14294659
 ] 

ASF GitHub Bot commented on TAJO-1320:
--------------------------------------

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/363#discussion_r23663805
  
    --- Diff: 
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseStorageConstants.java
 ---
    @@ -27,6 +27,7 @@
       public static final String META_SPLIT_ROW_KEYS_KEY = 
"hbase.split.rowkeys";
       public static final String META_SPLIT_ROW_KEYS_FILE_KEY = 
"hbase.split.rowkeys.file";
       public static final String META_ZK_QUORUM_KEY = "hbase.zookeeper.quorum";
    +  public static final String META_ZK_CLIENT_PORT = 
"hbase.zookeeper.property.clientPort";
    --- End diff --
    
    Thank you for your review.
    The name borrowed with HBase Constant class. I think that HBase users may 
be familiar with it compare than another name.


> HBaseStorageManager need to support Zookeeper Client Port.
> ----------------------------------------------------------
>
>                 Key: TAJO-1320
>                 URL: https://issues.apache.org/jira/browse/TAJO-1320
>             Project: Tajo
>          Issue Type: Improvement
>          Components: storage
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.10
>
>         Attachments: TAJO-1320.patch
>
>
> Currently, HBaseStorageManager just use Zookeeper Quorum host names. But I 
> think that users may want to change their Zookeeper client port. Thus, we 
> need to support that users can set the port. For reference, HBase defines the 
> port to ZOOKEEPER_CLIENT_PORT in HBaseConstants.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to