[ 
https://issues.apache.org/jira/browse/TAJO-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14294655#comment-14294655
 ] 

ASF GitHub Bot commented on TAJO-1320:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/363#discussion_r23663679
  
    --- Diff: 
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseStorageManager.java
 ---
    @@ -312,6 +312,17 @@ public static Configuration 
getHBaseConfiguration(Configuration conf, TableMeta
               HBaseStorageConstants.META_ZK_QUORUM_KEY + "' attribute.");
         }
     
    +    String zkPort = hbaseConf.get(HConstants.ZOOKEEPER_CLIENT_PORT);
    --- End diff --
    
    I wonder why we don't use the default value.
    Should users always specify the zookeeper client port?


> HBaseStorageManager need to support Zookeeper Client Port.
> ----------------------------------------------------------
>
>                 Key: TAJO-1320
>                 URL: https://issues.apache.org/jira/browse/TAJO-1320
>             Project: Tajo
>          Issue Type: Improvement
>          Components: storage
>            Reporter: Jaehwa Jung
>            Assignee: Jaehwa Jung
>             Fix For: 0.10
>
>         Attachments: TAJO-1320.patch
>
>
> Currently, HBaseStorageManager just use Zookeeper Quorum host names. But I 
> think that users may want to change their Zookeeper client port. Thus, we 
> need to support that users can set the port. For reference, HBase defines the 
> port to ZOOKEEPER_CLIENT_PORT in HBaseConstants.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to