[
https://issues.apache.org/jira/browse/TAJO-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366827#comment-14366827
]
ASF GitHub Bot commented on TAJO-1350:
--------------------------------------
Github user hyunsik commented on the pull request:
https://github.com/apache/tajo/pull/384#issuecomment-82821794
I leave some trivial comments on some java docs. Others are all good.
Especially, extractNonPushableOuterJoinQuals looks intuitive.
After you reflect my comment, I'll finish the review.
> Refactor FilterPushDownRule::visitJoin() into well-defined, small methods
> -------------------------------------------------------------------------
>
> Key: TAJO-1350
> URL: https://issues.apache.org/jira/browse/TAJO-1350
> Project: Tajo
> Issue Type: Improvement
> Components: planner/optimizer
> Reporter: Hyunsik Choi
> Assignee: Jihoon Son
> Fix For: 0.11.0
>
> Attachments: TAJO-1350.patch
>
>
> FilterPushDownRule::visitJoin() is too long and complicated. It handles
> various cases in a single method. We need to refactor this method into
> several small and well-defined methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
