[
https://issues.apache.org/jira/browse/TAJO-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385758#comment-14385758
]
ASF GitHub Bot commented on TAJO-1463:
--------------------------------------
Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/tajo/pull/476#issuecomment-87411421
Rebased and added error handling cases according to the discussion
https://issues.apache.org/jira/browse/TAJO-29.
When selecting non-empty ORCFile table, return IOException instead of NPE.
I think this is more general error handling way rather than throwing
NotImplementedException for a new specific storage type.
By the way, I welcome any feedback for the way of error handling.
> Add ORCFile store type to create ORCFile table
> ----------------------------------------------
>
> Key: TAJO-1463
> URL: https://issues.apache.org/jira/browse/TAJO-1463
> Project: Tajo
> Issue Type: Sub-task
> Components: storage
> Reporter: Dongjoon Hyun
> Assignee: Dongjoon Hyun
> Priority: Minor
> Attachments: TAJO-1463.Hyun.150329.0.patch.txt
>
>
> To support ORCFile, Tajo can recognize ORCFile as a store type.
> * Before
> {code}
> default> create table t(a int) using orcfile;
> ERROR: Store format orcfile is not supported.
> {code}
> * After
> {code}
> default> create table t1(a int) using orcfile;
> OK
> default> select * from t1;
> a
> -------------------------------
> (0 rows, 0.054 sec, 0 B selected)
> {code}
> For non-empty orcfile table, fix NPE error into the following normal process.
> {code}
> default> select * from orc1;
> ERROR: Unknown Storage Type: ORCFILE
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
