[ 
https://issues.apache.org/jira/browse/TAJO-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387764#comment-14387764
 ] 

ASF GitHub Bot commented on TAJO-1463:
--------------------------------------

Github user blrunner commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/476#discussion_r27446626
  
    --- Diff: 
tajo-storage/tajo-storage-common/src/main/java/org/apache/tajo/storage/StorageManager.java
 ---
    @@ -538,7 +538,8 @@ public Appender getAppender(OverridableConf 
queryContext,
         if (scannerClass == null) {
           scannerClass = conf.getClass(
               String.format("tajo.storage.scanner-handler.%s.class", 
handlerName), null, Scanner.class);
    -      SCANNER_HANDLER_CACHE.put(handlerName, scannerClass);
    +      if (scannerClass != null)
    --- End diff --
    
    Sorry @dongjoon-hyun 
    
    I wrote a typo for file format.
    I'll test it again. :)


> Add ORCFile store type to create ORCFile table
> ----------------------------------------------
>
>                 Key: TAJO-1463
>                 URL: https://issues.apache.org/jira/browse/TAJO-1463
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: storage
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Minor
>         Attachments: TAJO-1463.Hyun.150329.0.patch.txt, 
> TAJO-1463.Hyun.150329.1.patch.txt
>
>
> To support ORCFile, Tajo can recognize ORCFile as a store type.
> * Before
> {code}
> default> create table t(a int) using orcfile;
> ERROR: Store format orcfile is not supported.
> {code}
> * After
> {code}
> default> create table t1(a int) using orcfile;
> OK
> default> select * from t1;
> a
> -------------------------------
> (0 rows, 0.054 sec, 0 B selected)
> {code}
> For non-empty orcfile table, fix NPE error into the following normal process.
> {code}
> default> select * from orc1; 
> ERROR: Unknown Storage Type: ORCFILE
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to