[ 
https://issues.apache.org/jira/browse/TAJO-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387987#comment-14387987
 ] 

ASF GitHub Bot commented on TAJO-1463:
--------------------------------------

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/476#issuecomment-87938171
  
    It looks good Jihoon's opinion. And there are another way using 
PreLogicalPlanVerifier or LogicalPlanVerifier.
    
    But I would like you to proceed the umbrella issue in following order.
    1. Implement ORCAppender and ORCScanner
    2. Implement ORCStorageManager
    3. Added ORC type to Tajo grammer.
    
    I suggested above idea because we need to proceed development avoiding 
users confusion. Also if you want the umbrella issue to merge to the apache 
master branch, you need to complete all sub tasks before the next release. For 
reference, I don't intend to push you and I just mean to help your schedule.


> Add ORCFile store type to create ORCFile table
> ----------------------------------------------
>
>                 Key: TAJO-1463
>                 URL: https://issues.apache.org/jira/browse/TAJO-1463
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: storage
>            Reporter: Dongjoon Hyun
>            Assignee: Dongjoon Hyun
>            Priority: Minor
>         Attachments: TAJO-1463.Hyun.150329.0.patch.txt, 
> TAJO-1463.Hyun.150329.1.patch.txt
>
>
> To support ORCFile, Tajo can recognize ORCFile as a store type.
> * Before
> {code}
> default> create table t(a int) using orcfile;
> ERROR: Store format orcfile is not supported.
> {code}
> * After
> {code}
> default> create table t1(a int) using orcfile;
> OK
> default> select * from t1;
> a
> -------------------------------
> (0 rows, 0.054 sec, 0 B selected)
> {code}
> For non-empty orcfile table, fix NPE error into the following normal process.
> {code}
> default> select * from orc1; 
> ERROR: Unknown Storage Type: ORCFILE
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to