[
https://issues.apache.org/jira/browse/TAJO-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14394058#comment-14394058
]
ASF GitHub Bot commented on TAJO-1506:
--------------------------------------
GitHub user ykrips opened a pull request:
https://github.com/apache/tajo/pull/502
TAJO-1506: WorkerConnectionInfo::id field may be not unique, but its
uniqueness is assumed throughout codes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ykrips/tajo TAJO-1506
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/502.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #502
----
commit 84273653c5fd57af573c1bf73d846c1c0abc8922
Author: Jihun Kang <[email protected]>
Date: 2015-04-03T04:45:18Z
Initial Work
----
> WorkerConnectionInfo::id field may be not unique, but its uniqueness is
> assumed throughout codes.
> -------------------------------------------------------------------------------------------------
>
> Key: TAJO-1506
> URL: https://issues.apache.org/jira/browse/TAJO-1506
> Project: Tajo
> Issue Type: Improvement
> Components: query master, worker
> Reporter: Hyunsik Choi
> Assignee: Jihun Kang
> Fix For: 0.11.0
>
>
> WorkerConnectionInfo::id is a integer value. It is generated in Worker by a
> hashCode as follows:
> {code}
> public WorkerConnectionInfo(String host, int peerRpcPort, int pullServerPort,
> int clientPort,
> int queryMasterPort, int httpInfoPort) {
> ...
> this.queryMasterPort = queryMasterPort;
> this.httpInfoPort = httpInfoPort;
> this.id = hashCode();
> {code}
> Fundamentally, it uses hashCode method, so there are possibility to cause
> duplicate integer value. But, all codes assume its uniqueness. It is a
> potential problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
