[
https://issues.apache.org/jira/browse/TAJO-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396200#comment-14396200
]
Tajo QA commented on TAJO-1506:
-------------------------------
{color:red}*-1 overall.*{color} Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12709466/TAJO-1506_4.patch
against master revision release-0.9.0-rc0-237-gb0abff8.
{color:green}+1 @author.{color} The patch does not contain any @author
tags.
{color:green}+1 tests included.{color} The patch appears to include 1 new
or modified test files.
{color:green}+1 javac.{color} The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc.{color} The applied patch does not increase the
total number of javadoc warnings.
{color:green}+1 checkstyle.{color} The patch generated 0 code style errors.
{color:red}-1 findbugs.{color} The patch appears to introduce 2 new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit.{color} The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 core tests.{color} The patch failed these unit tests in
tajo-core:
org.apache.tajo.engine.query.TestSelectQuery
org.apache.tajo.engine.query.TestHBaseTable
org.apache.tajo.engine.query.TestJoinQuery
org.apache.tajo.engine.query.TestJoinBroadcast
org.apache.tajo.engine.query.TestTablePartitions
org.apache.tajo.engine.query.TestCTASQuery
org.apache.tajo.engine.query.TestGroupByQuery
org.apache.tajo.querymaster.TestTaskStatusUpdate
org.apache.tajo.engine.query.TestJoinOnPartitionedTables
Test results:
https://builds.apache.org/job/PreCommit-TAJO-Build/705//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-TAJO-Build/705//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/705//console
This message is automatically generated.
> WorkerConnectionInfo::id field may be not unique, but its uniqueness is
> assumed throughout codes.
> -------------------------------------------------------------------------------------------------
>
> Key: TAJO-1506
> URL: https://issues.apache.org/jira/browse/TAJO-1506
> Project: Tajo
> Issue Type: Improvement
> Components: query master, worker
> Reporter: Hyunsik Choi
> Assignee: Jihun Kang
> Fix For: 0.11.0
>
> Attachments: TAJO-1506.patch, TAJO-1506_1.patch, TAJO-1506_2.patch,
> TAJO-1506_3.patch, TAJO-1506_4.patch
>
>
> WorkerConnectionInfo::id is a integer value. It is generated in Worker by a
> hashCode as follows:
> {code}
> public WorkerConnectionInfo(String host, int peerRpcPort, int pullServerPort,
> int clientPort,
> int queryMasterPort, int httpInfoPort) {
> ...
> this.queryMasterPort = queryMasterPort;
> this.httpInfoPort = httpInfoPort;
> this.id = hashCode();
> {code}
> Fundamentally, it uses hashCode method, so there are possibility to cause
> duplicate integer value. But, all codes assume its uniqueness. It is a
> potential problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
