[jira] [Commented] (TAJO-1506) WorkerConnectionInfo::id field may be not unique, but its uniqueness is assumed throughout codes.

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/TAJO-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14395974#comment-14395974
 ] 

ASF GitHub Bot commented on TAJO-1506:
--------------------------------------

Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/502#issuecomment-89672537
  
    Thanks for your contribution.
    
    I tested this on four of linux servers. But I found that worker id had been 
duplicated as follows.
    
    ```
    2015-04-05 07:13:05,916 INFO org.apache.tajo.worker.TajoWorker: Tajo Worker 
is initialized. connection :id:1, host:tajo004.xyz, PeerRpcPort:28091, 
PullServerPort:53218, ClientPort:28092, QueryMasterPort:28093, 
HttpInfoPort:28080
    
    2015-04-05 07:13:05,054 INFO org.apache.tajo.worker.TajoWorker: Tajo Worker 
is initialized. connection :id:1, host:tajo005.xyz, PeerRpcPort:28091, 
PullServerPort:44162, ClientPort:28092, QueryMasterPort:28093, 
HttpInfoPort:28080
    ```
    
    So, TajoMaster can't show right TajoWorker list on web pages. Could you 
check this again?


> WorkerConnectionInfo::id field may be not unique, but its uniqueness is 
> assumed throughout codes.
> -------------------------------------------------------------------------------------------------
>
>                 Key: TAJO-1506
>                 URL: https://issues.apache.org/jira/browse/TAJO-1506
>             Project: Tajo
>          Issue Type: Improvement
>          Components: query master, worker
>            Reporter: Hyunsik Choi
>            Assignee: Jihun Kang
>             Fix For: 0.11.0
>
>         Attachments: TAJO-1506.patch
>
>
> WorkerConnectionInfo::id is a integer value. It is generated in Worker by a 
> hashCode as follows:
> {code}
> public WorkerConnectionInfo(String host, int peerRpcPort, int pullServerPort, 
> int clientPort,
>                               int queryMasterPort, int httpInfoPort) {
> ...
>     this.queryMasterPort = queryMasterPort;
>     this.httpInfoPort = httpInfoPort;
>     this.id = hashCode();
> {code}
> Fundamentally, it uses hashCode method, so there are possibility to cause 
> duplicate integer value. But, all codes assume its uniqueness. It is a 
> potential problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)