Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/442#discussion_r27778444
--- Diff: tajo-core/src/main/java/org/apache/tajo/session/Session.java ---
@@ -121,6 +124,10 @@ public synchronized String getCurrentDatabase() {
return currentDatabase;
}
+ public synchronized void setQueryCache(LoadingCache<String, Expr> cache)
{ this.cache = cache; }
--- End diff --
The cache instance is always updated instead of adding a cache item to a
singleton cache instance. I don't think that this is a valid cache operation.
In addition, please follow our coding convention.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
