Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/tajo/pull/442#discussion_r27782120
--- Diff: tajo-core/src/main/java/org/apache/tajo/session/Session.java ---
@@ -121,6 +124,10 @@ public synchronized String getCurrentDatabase() {
return currentDatabase;
}
+ public synchronized void setQueryCache(LoadingCache<String, Expr> cache)
{ this.cache = cache; }
--- End diff --
Currently, in this patch, I try to minimize dependency change in order to
keep Tajo's good modularity. So, I put only Expr dependency into Session class.
(It's inevitable.) If we put the cache initialization there, we need "import
org.apache.tajo.engine.parser.SQLAnalyzer" there. I am not sure that Tajo
allows this kind of dependency. If you think this is okay, I prefer to move
that into Session. I need your guide. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
