Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/442#discussion_r27781831
  
    --- Diff: tajo-core/src/main/java/org/apache/tajo/session/Session.java ---
    @@ -121,6 +124,10 @@ public synchronized String getCurrentDatabase() {
         return currentDatabase;
       }
     
    +  public synchronized void setQueryCache(LoadingCache<String, Expr> cache) 
{ this.cache = cache; }
    --- End diff --
    
    I've already read Jira. I concerned about whether the cache is maintained 
within a session. But it was my misunderstanding. I'm not familiar with 
LoadingCache. Sorry. 
    
    Anyway, it would be better if this cache initialization is moved to 
Session. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to