[
https://issues.apache.org/jira/browse/TAJO-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14516785#comment-14516785
]
ASF GitHub Bot commented on TAJO-1450:
--------------------------------------
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/465#discussion_r29230883
--- Diff:
tajo-core/src/main/java/org/apache/tajo/engine/planner/physical/RangeShuffleFileWriteExec.java
---
@@ -91,20 +91,25 @@ public void init() throws IOException {
@Override
public Tuple next() throws IOException {
Tuple tuple;
- Tuple keyTuple;
+ VTuple keyTuple;
Tuple prevKeyTuple = null;
long offset;
- while(!context.isStopped() && (tuple = child.next()) != null) {
- offset = appender.getOffset();
- appender.addTuple(tuple);
- keyTuple = new VTuple(keySchema.size());
- RowStoreUtil.project(tuple, keyTuple, indexKeys);
- if (prevKeyTuple == null || !prevKeyTuple.equals(keyTuple)) {
- indexWriter.write(keyTuple, offset);
- prevKeyTuple = keyTuple;
+ try {
+ while(!context.isStopped() && (tuple = child.next()) != null) {
+ offset = appender.getOffset();
+ appender.addTuple(tuple);
+ keyTuple = new VTuple(keySchema.size());
+ RowStoreUtil.project(tuple, keyTuple, indexKeys);
+ if (prevKeyTuple == null || !prevKeyTuple.equals(keyTuple)) {
+ indexWriter.write(keyTuple, offset);
+ prevKeyTuple = keyTuple;
+ }
}
+ } catch (RuntimeException e) {
+ e.printStackTrace();
--- End diff --
This block looks for debug.
> Encapsulate Datum in Tuple
> --------------------------
>
> Key: TAJO-1450
> URL: https://issues.apache.org/jira/browse/TAJO-1450
> Project: Tajo
> Issue Type: Task
> Reporter: Navis
> Assignee: Navis
> Priority: Minor
> Fix For: 0.11.0
>
>
> Currently, Tuple exposes Datum inside of it but it seemed not necessary(,
> which is not fully confirmed). If we remove Datum returning APIs from Tuple,
> Tuple can be implemented more effective and free. I think this can be a
> subtask of vectorization.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
