[ 
https://issues.apache.org/jira/browse/TAJO-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568401#comment-14568401
 ] 

ASF GitHub Bot commented on TAJO-1450:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/596#discussion_r31488745
  
    --- Diff: tajo-common/src/main/java/org/apache/tajo/storage/VTuple.java ---
    @@ -132,6 +140,11 @@ public char getChar(int fieldId) {
        }
     
       @Override
    +  public byte[] getTextBytes(int fieldId) {
    +    return values[fieldId].asTextBytes();
    +  }
    +
    +  @Override
        public short getInt2(int fieldId) {
    --- End diff --
    
    Thanks. I've adjusted indent.


> Encapsulate Datum in Tuple
> --------------------------
>
>                 Key: TAJO-1450
>                 URL: https://issues.apache.org/jira/browse/TAJO-1450
>             Project: Tajo
>          Issue Type: Task
>            Reporter: Navis
>            Assignee: Navis
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> Currently, Tuple exposes Datum inside of it but it seemed not necessary(, 
> which is not fully confirmed). If we remove Datum returning APIs from Tuple, 
> Tuple can be implemented more effective and free. I think this can be a 
> subtask of vectorization.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to